refactor: remove static_files.to_settings() and add edge feature to RocksDB flags#21225
Merged
refactor: remove static_files.to_settings() and add edge feature to RocksDB flags#21225
Conversation
Rjected
reviewed
Jan 20, 2026
Member
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
needs rebase / conflicts fixed
crates/cli/commands/src/common.rs
Outdated
Comment on lines
+78
to
+81
| #[cfg(feature = "edge")] | ||
| let base = StorageSettings::edge(); | ||
| #[cfg(not(feature = "edge"))] | ||
| let base = StorageSettings::legacy(); |
Member
There was a problem hiding this comment.
would be nice to wrap this in a fn
gakonst
force-pushed
the
fix/remove-static-files-to-settings
branch
4 times, most recently
from
82b3964 to
815895e
Compare
…ocksDB flags This PR addresses the review comment from #21191: - Remove `StaticFilesArgs::to_settings()` - superseded by `NodeConfig::storage_settings()` - Add edge feature behavior to RocksDB flags - flags default to `true` when `edge` feature is enabled - Add `RocksDbArgs` to `EnvironmentArgs` with `storage_settings()` method - Update `storage_settings()` to use `StorageSettings::edge()` or `StorageSettings::legacy()` base - Replace `static_files.to_settings()` calls with `storage_settings()` in launch/common.rs
gakonst
force-pushed
the
fix/remove-static-files-to-settings
branch
from
815895e to
a7aaafa
Compare
Rjected
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the review comment from #21191 (discussion):
Changes
Remove
StaticFilesArgs::to_settings()- This method is now superseded byNodeConfig::storage_settings()which handles both static files and RocksDB settings in one place.Add edge feature behavior to RocksDB flags - Following the pattern from fix: set
StaticFileArgsdefaults foredge#21208:tx_hash,storages_history,account_history) now default totruewhen theedgefeature is enabledOption<bool>toboolwith proper defaults usingdefault_value_tandArgAction::SetAdd RocksDbArgs to EnvironmentArgs - The
EnvironmentArgsincli/commandsnow includesRocksDbArgswith astorage_settings()method for consistent storage settings across all CLI commands.Update storage_settings() to use edge feature base - Both
NodeConfig::storage_settings()andEnvironmentArgs::storage_settings()now start fromStorageSettings::edge()orStorageSettings::legacy()based on the feature flag.Files Changed
crates/node/core/src/args/rocksdb.rs- Add edge feature defaults, change Option to boolcrates/node/core/src/args/static_files.rs- Removeto_settings()methodcrates/node/core/src/node_config.rs- Updatestorage_settings()to use edge feature basecrates/cli/commands/src/common.rs- AddRocksDbArgsandstorage_settings()crates/node/builder/src/launch/common.rs- Update callers to usestorage_settings()